This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: remove use of instanceof for CID class #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we use ipjs to publish esm modules as esm and cjs, consuming code can end up loading classes from different locations based on whether the consuming code is esm or cjs so `instanceof` becomes unreliable. Remove it's use with the CID class since we dual publish that one.
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
When we use ipjs to publish esm modules as esm and cjs, consuming code can end up loading classes from different locations based on whether the consuming code is esm or cjs so `instanceof` becomes unreliable. Remove its use with the CID class since we dual publish that one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use ipjs to publish esm modules as esm and cjs, consuming code
can end up loading classes from different locations based on whether
the consuming code is esm or cjs so
instanceofbecomes unreliable.Remove its use with the CID class since we dual publish that one.