This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: pull in new globSource #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new globSource module has a simpler api.
Old:
```js
await ipfs.addAll(globSource('*', {
recursive: true,
cwd: './somedir'
})
```
New:
```js
await ipfs.addAll(globSource('./somedir', '**/*'))
```
See the [minimatch](https://www.npmjs.com/package/minimatch) docs for
more on what the pattern supports.
BREAKING CHANGE: the globSource api has changed from `globSource(dir, opts)` to `globSource(dir, pattern, opts)`
achingbrain
force-pushed
the
chore/upgrade-ipfs-utils
branch
from
a3556b7
to
3de9d81
Compare
hacdias
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Feb 9, 2022
lidel
pushed a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Feb 11, 2022
* fix: use new glob source API See ipfs/js-ipfs#3889 * feat: add tests and improve add-to-ipfs
This was referenced Apr 8, 2022
This was referenced Apr 8, 2022
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
* feat: pull in new globSource
The new globSource module has a simpler api.
Old:
```js
await ipfs.addAll(globSource('*', {
recursive: true,
cwd: './somedir'
})
```
New:
```js
await ipfs.addAll(globSource('./somedir', '**/*'))
```
See the [minimatch](https://www.npmjs.com/package/minimatch) docs for
more on what the pattern supports.
BREAKING CHANGE: the globSource api has changed from `globSource(dir, opts)` to `globSource(dir, pattern, opts)`
This was referenced Oct 30, 2022
This was referenced Oct 30, 2022
This was referenced Oct 30, 2022
This was referenced Oct 30, 2022
This was referenced Oct 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new globSource module has a simpler api.
Old:
New:
See the minimatch docs for
more on what the pattern supports.
BREAKING CHANGE: the globSource api has changed from
globSource(dir, opts)toglobSource(dir, pattern, opts)