This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: do not lose files when writing files into subshards that contain other subshards #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other subshards When writing a file into a hamt shard we hash the filename to figure out where in the shard to place the file. If the hash means that we end up adding the file into an existing subshard that also contains another subshard, we should populate the other subshard's children otherwise they will not be there when we calculate the new CID for the subshard and they will be lost. Fixes #3921
lidel
pushed a commit
to ipfs/interop
that referenced
this pull request
Nov 23, 2021
Switch to version that includes ipfs/js-ipfs#3936
This was referenced Dec 13, 2021
This was referenced Jan 24, 2022
This was referenced Mar 18, 2022
This was referenced Mar 29, 2022
This was referenced Oct 18, 2022
This was referenced Dec 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a file into a hamt shard we hash the filename to figure out where in the
shard to place the file.
If the hash means that we end up adding the file into an existing subshard that also
contains another subshard, we should populate the other subshard's children otherwise
they will not be there when we calculate the new CID for the subshard and they will
be lost.
Fixes #3921