This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: remove abort-controller deps #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AbortController` and `AbortSignal` are global in all supported runtimes so we don't need the polyfill any more.
|
Nb. will need bitswap and libp2p releases before it's completely gone from the stack. |
clarkjoao
reviewed
Jan 18, 2022
|
Test failures are unrelated. |
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
`AbortController` and `AbortSignal` are global in all supported runtimes so we don't need the polyfill any more. BREAKING CHANGE: node 15+ is required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbortControllerandAbortSignalare global in all supported runtimes so we don't need the polyfill any more.