Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

DisableNatPortMap incorrectly documented? #4236

Closed
Sjord opened this issue Oct 19, 2022 · 2 comments
Closed

DisableNatPortMap incorrectly documented? #4236

Sjord opened this issue Oct 19, 2022 · 2 comments
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue topic/docs Documentation

Comments

@Sjord
Copy link

Sjord commented Oct 19, 2022

In CONFIG.md:

By default when running under nodejs, libp2p will try to use UPnP to open a random high port on your router for any TCP connections you have configured.

Set DisableNatPortMap to false to disable this behaviour.

However, I think this behaviour is disabled by setting DisableNatPortMap to true. Is that right? The Disable part of this setting inverses the setting.

@Sjord Sjord added the need/triage Needs initial labeling and prioritization label Oct 19, 2022
@welcome
Copy link

welcome bot commented Oct 19, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@achingbrain
Copy link
Member

Yes, this is incorrect - would you like to submit a quick PR that corrects the docs?

@achingbrain achingbrain added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue topic/docs Documentation good first issue Good issue for new contributors and removed need/triage Needs initial labeling and prioritization labels Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue topic/docs Documentation
Projects
No open projects
Development

No branches or pull requests

2 participants