Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper error propagation #723

Closed
poolsar42 opened this issue Mar 29, 2022 · 3 comments
Closed

Proper error propagation #723

poolsar42 opened this issue Mar 29, 2022 · 3 comments
Labels
need/author-input Needs input from the original author

Comments

@poolsar42
Copy link

Hello Everyone,

It's a simple (I hope) issue to fix: Proper error throwing and handling when config object in ipfsOptions isn't right.

Today I was trying to set a constructor, and used following:
ipfsOptions: { config: { Datastore: { StorageMax: '35GB', StorageGCWatermark: '99', }, }, }
Here, you can see I was trying to set StorageGCWatermark to a string. But it has to be int.
But instead of throwing an error it wasn't do anything. It was just ignoring config options and it was frustrating,

Thanks <3

@poolsar42 poolsar42 added the need/triage Needs initial labeling and prioritization label Mar 29, 2022
@poolsar42
Copy link
Author

Huh, I think this issue is duplicate from a previous one

I'll keep it just in case

@SgtPooki
Copy link
Member

@poolsar42 this should be resolved with the merging of #722. Can you confirm that this issue is resolved for you?

@SgtPooki SgtPooki added need/author-input Needs input from the original author and removed need/triage Needs initial labeling and prioritization labels Oct 19, 2022
@poolsar42
Copy link
Author

@SgtPooki nice! Let's close this issue for now, I'll open new one if something wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

No branches or pull requests

2 participants