Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: ipfs ping <peer.ID> #229

Closed
jbenet opened this issue Oct 29, 2014 · 7 comments
Closed

command: ipfs ping <peer.ID> #229

jbenet opened this issue Oct 29, 2014 · 7 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@jbenet
Copy link
Member

jbenet commented Oct 29, 2014

We need a command to ping nodes. The command should:

  • find the node (in the routing system)
  • connect to it
  • send pings to that node, wait for pongs, and print out RTT time (just like ping <ip addr>)
# can specify address
> ipfs ping /ip4/1.2.3.4/tcp/4001/QmUGTUcHSEHNCuMdVTmAzdG6ooybb24RU6bN2i75yXX2vm

# or use the routing system to discover it
> ipfs ping QmUGTUcHSEHNCuMdVTmAzdG6ooybb24RU6bN2i75yXX2vm
Ping /ip4/1.2.3.4/tcp/4001/QmUGTUcHSEHNCuMdVTmAzdG6ooybb24RU6bN2i75yXX2vm
Pong 0 time=13.254 ms
Pong 1 time=30.766 ms
^C
--- ping statistics ---
2 packets transmitted, 2 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 13.254/22.010/30.766/8.756 ms

or something like that.

@jbenet jbenet added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue ready labels Oct 29, 2014
@whyrusleeping
Copy link
Member

👍 + 💯

@whyrusleeping
Copy link
Member

@jbenet This command would make me super extra happy

@btc
Copy link
Contributor

btc commented Dec 8, 2014

Feel free to cherry-pick this if you want. I had started on it a few days ago.

f777332

@jbenet
Copy link
Member Author

jbenet commented Jan 8, 2015

@whyrusleeping is working on this now

@whyrusleeping
Copy link
Member

@jbenet until we get the ability to allow the user to cancel commands, ping is just going to run for a set number of times, which can be specified by a command line parameter. sound good?

@jbenet
Copy link
Member Author

jbenet commented Jan 8, 2015

@whyrusleeping sounds good!

@whyrusleeping
Copy link
Member

ping is merged into master, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants