Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete the recomendations from gometalinter and include in the test sequence #3953

Closed
zramsay opened this issue Jun 1, 2017 · 3 comments
Closed

Comments

@zramsay
Copy link
Contributor

zramsay commented Jun 1, 2017

codeclimate gets in the way for #3949 (context.TODO() is a legit function) and does not seem to provide added value over and above implementing this line. As well, AFAICT that file should be deduplicated with this one

The current workaround is to disable checking the TODO string using the config option for fixme. I can pick up this issue

@Kubuxu
Copy link
Member

Kubuxu commented Jun 1, 2017

It does provide a lot of added value as:

  1. it does incremental checking (important for golint)
  2. in future we would like to add gometalimter to it and then filtering in the codeclimate would be really good

@zramsay
Copy link
Contributor Author

zramsay commented Jun 1, 2017

gotcha. as long as your OK with this hack

@zramsay zramsay changed the title remove codeclimate integration & implement go vet/lint etc as part of testing sequence complete the recomendations from megacheck and include in the test sequence Jun 1, 2017
@zramsay
Copy link
Contributor Author

zramsay commented Jun 1, 2017

re-named the issue to reference the extension of #3949, which will come in future additional PR. feel free to assign the issue to me

@zramsay zramsay changed the title complete the recomendations from megacheck and include in the test sequence complete the recomendations from gometalinter and include in the test sequence Nov 18, 2017
@momack2 momack2 added this to Inbox in ipfs/go-ipfs May 9, 2019
@zramsay zramsay closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants