Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$IPFS_PATH/api blocks use of ipfs --local until removed #4214

Closed
elitak opened this issue Sep 6, 2017 · 5 comments
Closed

$IPFS_PATH/api blocks use of ipfs --local until removed #4214

elitak opened this issue Sep 6, 2017 · 5 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@elitak
Copy link

elitak commented Sep 6, 2017

Type: Bug

Severity: Medium

Description:

If the daemon gets killed violently, $IPFS_PATH/api and repo.lock are left behind. These get cleared on next start of the daemon, but if the user wishes to run any ipfs command using the --local=true flag before the next daemon startup, it will still try to use the defunct api endpoint instead of the local method. I think this behavior is probably unintended. Local commands should ignore and/or remove the api file in the IPFS_PATH.

@kevina
Copy link
Contributor

kevina commented Sep 6, 2017

A possible related issue is local command will just abort if the repo needs migration rather than offer to run the migration.

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Sep 7, 2017
@momack2 momack2 added this to Inbox in ipfs/go-ipfs May 9, 2019
@Stebalien
Copy link
Member

This has been fixed.

@elitak
Copy link
Author

elitak commented Apr 20, 2020

I'm running v0.4.23 and ipfs --local=true id still won't run if /var/lib/ipfs/api exists. I also need to run ipfs repo fsck to clear them when starting the daemon normally. This doesn't seem practical. What am I missing?

@hsanjuan
Copy link
Contributor

I think this meant that this is fixed on master or 0.5.0-rc2.

@Stebalien
Copy link
Member

It is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
No open projects
Development

No branches or pull requests

5 participants