Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files API Documentation (milestone main issue) #5050

Open
schomatis opened this issue May 30, 2018 · 2 comments
Open

Files API Documentation (milestone main issue) #5050

schomatis opened this issue May 30, 2018 · 2 comments
Labels
topic/docs-ipfs Topic docs-ipfs topic/files Topic files

Comments

@schomatis
Copy link
Contributor

The title is a bit misleading, this encompasses more than just adding some documentation to the ipfs files commands, my main target is a user who wants to know some of the inner workings of how are files implemented in IPFS and could follow some of the source code involved (to maybe become himself a contributor to the project instead of just a user). Some major points in order to achieve that could be:

  1. High level architecture document (inside docs) that could serve as a starting point on where to go looking for the code.

  2. Meaningful comments for key data structures and the methods they implement.

  3. Refactoring of variable and function names to make them more readeble and descriptive, I would favor legibility instead of compactness (IMO).

  4. [Optional and more aggressive modifications] Refactor some code paths to make the code easier to follow.

(The milestone doesn't have all the text formatting capabilities of an issue so I'll document the milestone itself here.)

@schomatis schomatis added topic/docs-ipfs Topic docs-ipfs topic/files Topic files labels May 30, 2018
@schomatis schomatis added this to the Files API Documentation milestone May 30, 2018
@schomatis schomatis self-assigned this May 30, 2018
@Mr0grog
Copy link
Contributor

Mr0grog commented Jun 2, 2018

Would writing a short example/tutorial of creating a Go application that does something with the files API (adds a file? lists your files?) be a good way to identify or demonstrate what’s most ugly/confusing/hard-to-explain inside the go-ipfs package? It would be wonderful to have that example for documentation, too :)

@schomatis
Copy link
Contributor Author

@Mr0grog Yes! Actually I'm working on something like that in #5052 (I'm glad we're aligned on this), I'll ping you when I have it at a more mature stage to get your feedback.

@momack2 momack2 added this to Inbox in ipfs/go-ipfs May 9, 2019
@daviddias daviddias added docs and removed docs labels Oct 1, 2019
@Stebalien Stebalien removed this from the Files API Documentation milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/docs-ipfs Topic docs-ipfs topic/files Topic files
Projects
No open projects
Development

No branches or pull requests

4 participants