Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No cache-control on Host: based requests #5968

Closed
Kubuxu opened this issue Feb 4, 2019 · 2 comments
Closed

No cache-control on Host: based requests #5968

Kubuxu opened this issue Feb 4, 2019 · 2 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/duplicate This issue or pull request already exists
Projects
ipfs/go-ipfs

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Feb 4, 2019

On domain based requests we should use ETag base cache. We are currently not doing this.
The solution is to send Cache-control: public as the ETag is already sent.
@Kubuxu Kubuxu added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Feb 4, 2019
@magik6k
Copy link
Member

magik6k commented Feb 4, 2019

cc @lidel

@lidel
Copy link
Member

lidel commented Feb 16, 2019

I believe this is a duplicate of https://github.com/ipfs/go-ipfs/issues/1818#issuecomment-450866591

@lidel lidel mentioned this issue Feb 16, 2019
Open
22 tasks
@momack2 momack2 added this to Inbox in ipfs/go-ipfs May 9, 2019
@lidel lidel closed this as completed Jan 18, 2022
@lidel lidel added the status/duplicate This issue or pull request already exists label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/duplicate This issue or pull request already exists
Projects
No open projects
ipfs/go-ipfs
Inbox
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @Kubuxu @magik6k