Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de-duplicate blockservice providing #609

Closed
btc opened this issue Jan 21, 2015 · 1 comment
Closed

de-duplicate blockservice providing #609

btc opened this issue Jan 21, 2015 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@btc
Copy link
Contributor

btc commented Jan 21, 2015

When a file is added twice in quick succession, blocks are queued up to be provided twice.

ipfs add large_file # provides to network
ipfs add large_file # provides to network again (even if previous keys are still in the queue)

It may make sense to allow re-providing if the RPCs have already gone out. Doesn't make sense at all when the blocks are still waiting to go out the first time.
@btc btc added the kind/enhancement A net-new feature or improvement to an existing feature label Jan 21, 2015
@jbenet
Copy link
Member

jbenet commented Jan 21, 2015

👍

@btc btc mentioned this issue Jan 22, 2015
Merged
@btc btc closed this as completed Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbenet @btc