You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Probably --raw-leaves should not return base32 cids if the user did not select them. What I'm more worried about is that some outputs (adding with wrapping folders, refs -r...) may contain V0 cids with base58 and V1 cids with base32 all mixed regardless of user choice which is bad UI.
Feel free to close if this is not actionable (should auto-fix whenever we switch to V1 cids by default). Just wanted to bring it up and --raw-leaves are experimental anyways. Fixing this is probably just going to add more boilerplate.
The text was updated successfully, but these errors were encountered:
I mean... I'm tempted to just say "CIDv1 on raw leaves FTW!". I'm not sure why we didn't go with that in the first place. Unfortunately, that would make a bunch of people very unhappy (I think?).
Actually, @parkan, is what flags are the Internet Archive using? Are they using CIDv1 by default? --raw-leaves is experimental so I'm fine changing the defaults if it doesn't break any known users.
Version information: master
Description:
Probably
--raw-leaves
should not return base32 cids if the user did not select them. What I'm more worried about is that some outputs (adding with wrapping folders, refs -r...) may contain V0 cids with base58 and V1 cids with base32 all mixed regardless of user choice which is bad UI.Feel free to close if this is not actionable (should auto-fix whenever we switch to V1 cids by default). Just wanted to bring it up and
--raw-leaves
are experimental anyways. Fixing this is probably just going to add more boilerplate.The text was updated successfully, but these errors were encountered: