Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--raw-leaves leads to base32 and base58 mixed outputs #6343

Open
hsanjuan opened this issue May 16, 2019 · 1 comment
Open

--raw-leaves leads to base32 and base58 mixed outputs #6343

hsanjuan opened this issue May 16, 2019 · 1 comment
Labels
need/community-input Needs input from the wider community

Comments

@hsanjuan
Copy link
Contributor

Version information: master

Description:

Probably --raw-leaves should not return base32 cids if the user did not select them. What I'm more worried about is that some outputs (adding with wrapping folders, refs -r...) may contain V0 cids with base58 and V1 cids with base32 all mixed regardless of user choice which is bad UI.

$ ipfs add --raw-leaves -Q bigfile.bin 
QmQnNC6QxkAuzAU8pejigkzNxUVGV9W8VvG6qKN1jh8i8M
$ ipfs add --raw-leaves -Q smallfile.bin  
bafkreigga22iwqldlydhd2bui4dbfowa3jjhdnrocvetm254k3blegqz5a

Feel free to close if this is not actionable (should auto-fix whenever we switch to V1 cids by default). Just wanted to bring it up and --raw-leaves are experimental anyways. Fixing this is probably just going to add more boilerplate.

@Stebalien
Copy link
Member

I mean... I'm tempted to just say "CIDv1 on raw leaves FTW!". I'm not sure why we didn't go with that in the first place. Unfortunately, that would make a bunch of people very unhappy (I think?).

Actually, @parkan, is what flags are the Internet Archive using? Are they using CIDv1 by default? --raw-leaves is experimental so I'm fine changing the defaults if it doesn't break any known users.

@Stebalien Stebalien added the need/community-input Needs input from the wider community label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/community-input Needs input from the wider community
Projects
None yet
Development

No branches or pull requests

2 participants