Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run js interop tests in Circle #6393

Closed
magik6k opened this issue May 31, 2019 · 4 comments
Closed

Run js interop tests in Circle #6393

magik6k opened this issue May 31, 2019 · 4 comments
Assignees
@magik6k
Labels
kind/enhancement A net-new feature or improvement to an existing feature topic/process Topic process

Comments

@magik6k
Copy link
Member

magik6k commented May 31, 2019

To keep things like #6389 from happening
@magik6k magik6k added kind/enhancement A net-new feature or improvement to an existing feature topic/process Topic process labels May 31, 2019
@magik6k magik6k self-assigned this May 31, 2019
@Stebalien
Copy link
Member

@magik6k how do we make this happen without blocking PRs. IIRC, interop tests can take >20 minutes. Is it possible to schedule nightly tests runs in Circle?

@magik6k
Copy link
Member Author

magik6k commented Jun 4, 2019

Afaik Yes.

Also, wouldn't just marking the check as optional be enough?

@Stebalien
Copy link
Member

Also, wouldn't just marking the check as optional be enough?

Yeah, actually, it should. Especially if we get emails on failure.

@magik6k magik6k mentioned this issue Jun 5, 2019
Merged
@Stebalien
Copy link
Member

Stebalien commented Jun 5, 2019 •
edited
Loading

Tracking broken tests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magik6k magik6k

Labels
kind/enhancement A net-new feature or improvement to an existing feature topic/process Topic process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @magik6k