Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradable default config values/profiles #6531

Open
Stebalien opened this issue Jul 18, 2019 · 0 comments
Open

Upgradable default config values/profiles #6531

Stebalien opened this issue Jul 18, 2019 · 0 comments
Labels
kind/feature A new feature topic/config Topic config

Comments

@Stebalien
Copy link
Member

Currently, profiles and many of our default config values are written to the config. Unfortunately, this makes it hard for us to change them for existing users, even when the user hasn't explicitly chosen to override something.

Proposal:

  1. Mostly empty on-disk config by default.
  2. Add a "profiles" section to the config that lists all the profiles that should be applied and in what order.
  3. Add "DefaultX: bool"/"CustomX: value" options where applicable (e.g., bootstrappers), to allow users to extend defaults.

At runtime, we'd:

  1. Read the config.
  2. Apply the defaults to the in-memory config.
  3. Apply the profiles to the in-memory config.

When updating the config, we'd:

  1. Re-read the on-disk config.
  2. Apply the update to the on-disk config without persisting the in-memory config (unless necessary?).
@Stebalien Stebalien added kind/feature A new feature topic/config Topic config labels Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A new feature topic/config Topic config
Projects
None yet
Development

No branches or pull requests

1 participant