New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double datastore measurements #6877

Open

Stebalien opened this issue Feb 6, 2020 · 1 comment

Labels

kind/bug

Member

Stebalien commented Feb 6, 2020

We're measuring datastore puts, gets, etc. in two places:

In the config, we wrap each sub-datastore with a measure datastore.
In the fsrepo code, we wrap the final datastore in a global measure datastore.

On one hand, this gives us a nice global view into datastore stats. On the other hand, this seems like duplicate work:

When we only have one datastore, we're just duplicating work.
We should be able to get all the stats we're looking for by combining the measurements from both datastores (I think?).

Stebalien added the kind/bug label

Stebalien mentioned this issue

Migration 11-12: migrate CIDsv1 to raw multihashes ipfs/fs-repo-migrations#95

Merged

Contributor

MichaelMure commented Feb 8, 2020

Another approach would be to remove (or make optional) those in favor of tracing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment