Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharness passes when expected failures start passing #7117

Open
Stebalien opened this issue Apr 8, 2020 · 2 comments · Fixed by #7152
Open

Sharness passes when expected failures start passing #7117

Stebalien opened this issue Apr 8, 2020 · 2 comments · Fixed by #7152
Labels
kind/test Testing work

Comments

@Stebalien
Copy link
Member

Version information:

v0.5.0-rc1

Description:

When an expected failure starts passing, make test and CI should fail. However, while sharness will print out that these expected failures have started passing, it won't fail the tests in general.
@Stebalien Stebalien added the kind/test Testing work label Apr 8, 2020
@Stebalien Stebalien added this to the go-ipfs 0.5 milestone Apr 9, 2020
@Stebalien Stebalien mentioned this issue Apr 9, 2020
Closed
71 tasks
@Stebalien Stebalien assigned aschmahmann and unassigned ribasushi Apr 13, 2020
@Stebalien
Copy link
Member Author

Example:

https://app.circleci.com/pipelines/github/ipfs/go-ipfs/2403/workflows/339e010b-1afc-4de0-9e10-de642fe3eb4b/jobs/29268/tests

@Stebalien Stebalien mentioned this issue Apr 14, 2020
Merged
@Stebalien Stebalien reopened this Apr 14, 2020
@Stebalien
Copy link
Member Author

Well, we fixed the specific bug. But the sharness tests still need to fail if known failures start passing.

@Stebalien Stebalien removed this from the go-ipfs 0.5 milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/test Testing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: invalidate cache on failed publish ipfs/kubo
3 participants
@Stebalien @ribasushi @aschmahmann