Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit CoreAPI for cases where the context should be canceled internally #7200

Open
Stebalien opened this issue Apr 23, 2020 · 2 comments
Open
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now

Comments

@Stebalien
Copy link
Member

Version information:

v0.5.0-rc3

Description:

There are several places in the CoreAPI (e.g., Ls) where we're assuming the context will be canceled when the caller is done. If that doesn't happen, we won't cleanup some resources.

Luckily, we are canceling these contexts. However, we shouldn't require that.

@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Apr 23, 2020
@hsanjuan
Copy link
Contributor

@Stebalien may I ask to associate priority to this, and whether this is Help Wanted (in which case it probably needs difficulty and effort tags).

@Stebalien Stebalien added exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue P3 Low: Not priority right now labels Apr 27, 2020
@Stebalien
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

2 participants