Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket activation via Unix Domain Sockets #7463

Closed
Ericson2314 opened this issue Jun 11, 2020 · 5 comments
Closed

Socket activation via Unix Domain Sockets #7463

Ericson2314 opened this issue Jun 11, 2020 · 5 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Ericson2314
Copy link

It looks like:

  1. add systemd support #6675 adds support for socket activation via tcp
  2. daemon: support unix domain sockets for the API/gateway #6678 adds support unix domain sockets

But there is no support for socket activation via unix domain sockets. I would like this. Is this something people would be interested in adding?

@Ericson2314 Ericson2314 added the kind/enhancement A net-new feature or improvement to an existing feature label Jun 11, 2020
@welcome
Copy link

welcome bot commented Jun 11, 2020

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@Stebalien
Copy link
Member

This already works. Just add ListenStream=/path/to/my.socket to your systemd socket unit.

@Ericson2314
Copy link
Author

Ericson2314 commented Jun 11, 2020

@Stebalien awesome! Do I need to specify the path anywhere else (e.g. with ipfs config), is the new line in socket unit sufficient?

@Stebalien
Copy link
Member

You don't need to specify anything in your config unless you want to. If you do specify the socket in your config, go-ipfs will listen on that socket even when the systemd socket unit is disabled but that's not necessary.

@Ericson2314
Copy link
Author

Alright, thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants