Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdomain gateway redirect ipns key to libp2p-key base32 instead of libp2p-key base36 #7544

Closed
xmaysonnave opened this issue Jul 16, 2020 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@xmaysonnave
Copy link

Version information:

go-ipfs version: 0.6.0
Repo version: 10
System version: amd64/linux
Golang version: go1.14.4

1 - Initial key gen cidv0 ed25519
cidv0 ed25519
Converted in libp2p-key cidv1 base32
libp2p-key cidv1 base32
Converted in libp2p-key cidv1 base 36
libp2p-key cidv1 base 36

2 - First test with a public gateway who do not support yet subdomains
The three urls are resolved. Each page is loaded and displayed
cidv0 ed25519
libp2p-key cidv1 base32
libp2p-key cidv1 base 36

3 - Second test with a public gateway who support subdomains

cidv0 ed25519
redirects to
https://bafzaajaiaejcbxrt4db3xaqro23sjw4v2imrj2gvu47udglwbrovzave4orrkaam.ipns.dweb.link/
The page is not loaded

libp2p-key cidv1 base32
redirects to
https://bafzaajaiaejcbxrt4db3xaqro23sjw4v2imrj2gvu47udglwbrovzave4orrkaam.ipns.dweb.link/
The page is not loaded

libp2p-key cidv1 base 36
redirects to
https://bafzaajaiaejcbxrt4db3xaqro23sjw4v2imrj2gvu47udglwbrovzave4orrkaam.ipns.dweb.link/
The page is not loaded

4 - Third test
libp2p-key cidv1 base 36
The page is loaded as expected.

Thanks

@xmaysonnave xmaysonnave added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jul 16, 2020
@xmaysonnave
Copy link
Author

As a final test. on my local ipfs server the tests are consistent.

  • localhost:8080 redirects an ipns key to its libp2p-key base32 representation and fails to load
  • 127.0.0.:80801 loads the three cid representations
    Thanks

@aschmahmann
Copy link
Contributor

aschmahmann commented Jul 31, 2020

This should be resolved by #7441 and available in the next release, feel free to reopen if you're still running into issues with this on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants