Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ipfs add -n FILE" should not require "ipfs init" #7990

Open
chevdor opened this issue Mar 18, 2021 · 2 comments
Open

"ipfs add -n FILE" should not require "ipfs init" #7990

chevdor opened this issue Mar 18, 2021 · 2 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now

Comments

@chevdor
Copy link

chevdor commented Mar 18, 2021

Version information:

go-ipfs version: 0.8.0
Repo version: 11
System version: amd64/linux
Golang version: go1.15.8

Description:

When adding a file using -n (--only-hash), there should not be the need to initialize the IPFS repo.
Currently, if you install ipfs but don't run ipfs init(or cleanup using rm -rf ~/.ipfs), ipfs add -n FILE will fail with:

Error: no IPFS repo found in /root/.ipfs.
please run: 'ipfs init'

So it is correct that no IPFS repo can be found but that should not be required to only hash.
@chevdor chevdor added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Mar 18, 2021
@Stebalien Stebalien added exp/expert Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week P3 Low: Not priority right now and removed need/triage Needs initial labeling and prioritization labels Mar 25, 2021
@Stebalien
Copy link
Member

Ideally, we wouldn't require the repo in this case.

Unfortunately, we open the repo long before we process these flags so fixing this is far from trivial and probably won't happen any time soon.

@QuAzI
Copy link

QuAzI commented Oct 3, 2022

Is file hash/ipfs url depends on repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stebalien @chevdor @QuAzI