Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not announce non-dialable addresses #9858

Open
3 tasks done
hacdias opened this issue May 5, 2023 · 2 comments
Open
3 tasks done

Do not announce non-dialable addresses #9858

hacdias opened this issue May 5, 2023 · 2 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@hacdias
Copy link
Member

hacdias commented May 5, 2023 •
edited
Loading

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

Right now, Kubo let's us put addresses in Addresses.Announce that we do not listen on and are, therefore, not dialable. It doesn't really make sense to be able to advertise addresses we do not listen on. This is a potential improvement. Right now I think it can also create some confusion, such as in #9823.

See #9857 (comment)

cc @aschmahmann
@hacdias hacdias added the kind/enhancement A net-new feature or improvement to an existing feature label May 5, 2023
@BigLep
Copy link
Contributor

BigLep commented May 18, 2023

@hacdias : I put this in 0.22 "Best Effort Track". Let me know if you disagree.

@guillaumemichel
Copy link

We also probably don't want local addresses to be advertised globally (for Kademlia see libp2p/go-libp2p-kad-dht#839)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
No open projects
IPFS Shipyard Team
Status: 🥞 Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BigLep @hacdias @guillaumemichel