added key_gen function to client #86
Conversation
ipfsapi/client.py
Outdated
| @@ -743,6 +743,42 @@ def resolve(self, name, recursive=False, **kwargs): | |||
| args = (name,) | |||
| return self._client.request('/resolve', args, decoder='json', **kwargs) | |||
|
|
|||
| def key_gen(self, keyName, type='rsa', size='2048', **kwargs): | |||
There was a problem hiding this comment.
Please make type a mandatory argument (we don't want to hard-code a crypto type that may eventually become obsolete) and size an int.
There was a problem hiding this comment.
Also please write key_name instead of keyName – we use snake_case everywhere else, no point in introducing any inconsistency here.
ipfsapi/client.py
Outdated
| keyName : str | ||
| Name of the new Key to be generated. Used to reference the Keys. | ||
| type : str | ||
| Type of key to generate |
There was a problem hiding this comment.
Please list the currently possible key types (rsa, ed25519) here so that they appear in the API documentation
ipfsapi/client.py
Outdated
| dict : Key name and Key Id | ||
| """ | ||
|
|
||
| existingKeys = self._client.request('/key/list', decoder='json')['Keys'] |
There was a problem hiding this comment.
See the above comment about snake_case.
|
@Alexander255 The problem here seems to be a couple of style errors and a functional test that crashes the running ipfs node. That could be resolved by using the later version of IPFS though, so it may be worth rebasing on top of master? |
|
Yes, @sunnya97, please rebase onto master… most of the CI errors should now be fixed. Also please run Thanks so much for helping us keeping the library updated! 😀 |
|
Updated! |
Useful for creating new keys in order to push multiple objects to the IPNS namespace using name_publish.