max allowed pods check in cluster_k8s.go #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
max-allowed-pods
branch
2 times, most recently
from
812e154
to
75b8e7f
Compare
nonsense
force-pushed
the
max-allowed-pods
branch
from
75b8e7f
to
0636692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple check before we try to schedule pods to Kubernetes to make sure we have enough resources.
If we don't do that and a user requests 1000 pods, and has for example only 3-4 workers, then pods would go into
Pendingstate, and wait for available resources, which will never come as we currently don't have auto-scaling.Fixes: #498
TODO: