refactor: Upgrade to react-router@2 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
router
branch
2 times, most recently
from
26f7ff6
to
2669d7c
Compare
dignifiedquire
changed the title
|
Tests pass locally in Chrome, fail only in firefox because of bevry/sortobject#2 |
| @@ -0,0 +1,17 @@ | |||
| import React, {PropTypes} from 'react' | |||
There was a problem hiding this comment.
Because that's something different. To use jsx you need to have the top level React in scope, and for the PropTypes I don't want to write React.PropTypes. For more details see this article
There was a problem hiding this comment.
Hmm, interesting. Interesting shorthand I hadn't seen before. Thanks.
|
This all looks good to me, from what I understood of it. |
RichardLitt
added a commit
that referenced
this pull request
Jan 3, 2016
refactor: Upgrade to react-router@2
|
You! You're on 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also upgrades the test story to be more
useful as I found some issues with the one before.
So this superseeds #154.
Closes #131