Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTPS records #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkl-caliber
Copy link

@jkl-caliber jkl-caliber commented Feb 3, 2022

HTTPS is a new DNS record type with increasing support.

https://blog.cloudflare.com/speeding-up-https-and-http-3-negotiation-with-dns/

This patch adds support to dnschef. The associated PR has been filed against dnslib. The new functionality in dnschef depends on that new code.

paulc/dnslib#33

@andyacer
Copy link

I think this needs more code to work? When trying to use the code in this PR I get the following error:

          _                _          __
         | | version 0.4  | |        / _|
       __| |_ __  ___  ___| |__   ___| |_
      / _` | '_ \/ __|/ __| '_ \ / _ \  _|
     | (_| | | | \__ \ (__| | | |  __/ |
      \__,_|_| |_|___/\___|_| |_|\___|_|
                   iphelix@thesprawl.org

(15:24:49) [*] DNSChef started on interface: 127.0.0.1
(15:24:49) [*] Using the following nameservers: 8.8.8.8
(15:24:49) [*] Cooking A replies for domain testflight.apple.com with '192.168.8.221'
WARNING: DNS Record 'HTTPS' is not supported. Ignoring section contents.

@jkl-caliber
Copy link
Author

Are you using a patched copy of dnslib? paulc/dnslib#35

@andyacer
Copy link

ah sorry, no, I'd assumed that dnslib had incorporated the PR you mentioned. I'll try that, thanks!

@andyacer
Copy link

andyacer commented Jul 26, 2022

Followup - dnslib merged in your other PR - dnschef should merge this one too =) It's working great now that dnslib is updated, thanks for submitting both of those PRs.

@jkl-caliber jkl-caliber reopened this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants