Make events const and remove unused argument.

[tvladyslav]

Reference issue TokTok#1185

[tvladyslav]

@iphydf review this PR, please.

[iphydf]

Run other/astyle/format-source.

[tvladyslav]

@iphydf , format-source fixes 16 files, but there are no complains about the code, that I've edited.

        modified:   toxav/groupav.c
        modified:   toxav/groupav.h
        modified:   toxcore/Messenger.c
        modified:   toxcore/TCP_connection.c
        modified:   toxcore/TCP_connection.h
        modified:   toxcore/group.c
        modified:   toxcore/group_announce.c
        modified:   toxcore/group_announce.h
        modified:   toxcore/group_chats.c
        modified:   toxcore/group_chats.h
        modified:   toxcore/group_connection.c
        modified:   toxcore/group_moderation.c
        modified:   toxcore/onion_announce.c
        modified:   toxcore/onion_client.c
        modified:   toxcore/tox.c
        modified:   toxcore/tox.h

[iphydf]

Ok, only toxcore/tox.h needs to be updated there.

[tvladyslav]

Take a look at 4fbd899. astyle change is veeery suspicious.

[iphydf]

Ah yes, makes sense. TokTok#1173 would need to be fixed first. In the meantime, just change the callbacks to not take a user_data.

[iphydf]

E.g. https://github.com/iphydf/c-toxcore/blob/ngc-rebased-master/toxcore/tox.h#L3796 has user_data, but https://github.com/iphydf/c-toxcore/blob/ngc-rebased-master/toxcore/tox.h#L2509 does not. None of the callbacks registration functions should get a user_data parameter. The user_data should come from tox_iterate only.

[tvladyslav]

Yes, I've removed user_data in the first commit. Together with assertions. Take a look :)

[iphydf]

Ok, thanks. Can you update the tests so they compile with this change?

[iphydf]

Also take a look at line 751. There are a bunch of callback registration calls there which cause user data to be "tox". Those need to also not get any user data, because the user data should come from tox_iterate.

[iphydf]

Also, update auto_tests/group_message_test.c line 30 to print state->index.

[tvladyslav]

@iphydf how to run tests?

user@localhost:_build$ make test
Running tests...
Test project /home/user/github/c-toxcore/_build
No tests were found!!!

[robinlinden]

@crypto-universe You need to set the AUTOTEST CMake option.
$ cmake .. -DAUTOTEST=ON

[iphydf]

c-toxcore/auto_tests/group_announce_test.c:74:5: error: too many arguments to function ‘tox_callback_group_invite’
     tox_callback_group_invite(toxes[1], group_invite_handler, nullptr);

These are some errors that need to be fixed. I realised that the issue specification was not very precise, so I'm going to accept this solution to it, even though the real solution is a lot more work. I'll file a separate issue for the remainder of the work.

[tvladyslav]

Wait a second, in a few minutes there will be a working (at least compiling) solution.

[iphydf]

error: ‘global_state_tox0’ undeclared (first use in this function)

It'll need to move up. But also, let's not do this in this PR, because what we actually want is no use of global state in this test. If you do that, you'll notice it's quite a bit of work.

[tvladyslav]

My fault. Trivial change, so I didn't check if it compiles.