make myip command not cache by default
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmanShahzad
reviewed
Jul 19, 2022
There was a problem hiding this comment.
I wouldn't remove the flag, that breaks backwards compatibility and someone may be using it in some script somewhere to disable the cache already.
We can just introduce a new flag --cache which defaults to false and make the cache behave such that:
--cacheis off and--nocacheis off, then disable cache.--cacheis off and--nocacheis on, then disable cache.--cacheis on and--nocacheis on, then disable cache.--cacheis on and--nocacheis off, then enable cache.
So fNoCache = fNoCache || !fCache.
|
Considerably simpler solution was just to have |
UmanShahzad
reviewed
Jul 19, 2022
|
Yup, I tested it... |
UmanShahzad
approved these changes
Jul 20, 2022
|
Will release it a bit later grouped with some more changes. Thanks a ton! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #88
--cacheflag will enable the cache if someone wishes to enable it.- M