This repository has been archived by the owner on May 6, 2024. It is now read-only.
add cachable modifier to methods #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guseggert FYI, whenever you are done with deployment to production, we should get back to this PR and merge it. This one implements the latest Reframe spec involving ETags. |
|
Rebased. Tests in go-delegated-routing aren't working with this yet, so need to resolve that. |
|
Okay I fixed up the tests in go-delegated-routing and this all looks okay. |
guseggert
approved these changes
Sep 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ipfs/specs#282 and ipfs/specs#287.
[x] add cachable modifier to method definitions
[x] use
GETfor cachable methods,POSTfor others[x] servers deny
GETrequests for non-cachable methods[x] servers generate
ETagfor cachable methods[x] servers support
If-None-Matchfor cachable methods