Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-test package #129

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Use go-test package #129

merged 4 commits into from
Jun 27, 2024

Conversation

gammazero
Copy link
Contributor

The ipfs/go-test a replacement for ipni/storetheindex/test.

The ipfs/go-test a replacement for ipni/storetheindex/test.
@rvagg
Copy link
Member

rvagg commented Jun 27, 2024

Why does it pull in boxo? It's like a virus. One of the original goals here was to produce something that didn't touch the boxo, go-unixfs, and legacy stack. Kind of unavoidable I guess and "legacy" is probably not appropriate anymore given the abandonment of the new ipld stack. 🤷

@gammazero
Copy link
Contributor Author

gammazero commented Jun 27, 2024

That is very strange. ipfs/go-test has no direct or indirect dependency on boxo. Also, when I manually remove it from go.mod and run go mod tidy it does not put it back. All tests and build seem to work fine without boxo. I think maybe go mod tidy is slightly broken somehow.

@gammazero
Copy link
Contributor Author

Looks like I can also remove the indirect dependency on go-unixfs.

@rvagg rvagg merged commit 8092e13 into ipld:master Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants