Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CID decoding functionality to go-cid #91

Closed
masih opened this issue Jun 21, 2021 · 3 comments
Closed

Move CID decoding functionality to go-cid #91

masih opened this issue Jun 21, 2021 · 3 comments
Assignees
@mvdan
Labels
P2 Medium: Good to have, but can wait until someone steps up v2-before-release
Milestone
CARv2 v2.0.0

Comments

@masih
Copy link
Member

masih commented Jun 21, 2021

See ipfs/go-cid#126
@masih masih added this to the CAR v2 milestone Jun 21, 2021
@masih masih mentioned this issue Jun 21, 2021
Merged
@willscott willscott added the P2 Medium: Good to have, but can wait until someone steps up label Jun 29, 2021
@mvdan
Copy link
Contributor

mvdan commented Jul 2, 2021

Now happening at ipfs/go-cid#127. A demo of it working on top of the wip-v2 branch: a68e234

@mvdan
Copy link
Contributor

mvdan commented Jul 5, 2021

I started using the go-cid branch in our wip-v2, but we're still pending the merge into go-cid.

@masih masih mentioned this issue Jul 6, 2021
Merged
@mvdan mvdan self-assigned this Jul 13, 2021
masih pushed a commit that referenced this issue Jul 15, 2021
@mvdan @masih
use the now-merged cid.CidFromReader
20011d0 
Fixes #91.
@mvdan
Copy link
Contributor

mvdan commented Jul 15, 2021

The last commit there updated our go-cid dependency to the latest master, since the upstream PR got merged.

@mvdan mvdan closed this as completed Jul 15, 2021
mvdan added a commit that referenced this issue Jul 16, 2021
@mvdan
use the now-merged cid.CidFromReader
a2cd464 
Fixes #91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdan mvdan

Labels
P2 Medium: Good to have, but can wait until someone steps up v2-before-release
Projects
None yet
Milestone
CARv2 v2.0.0
Development

No branches or pull requests
3 participants
@masih @willscott @mvdan