Replace codegen with bindnode and add plain IPLD schema #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/rm-codegen-4-bindnode
branch
from
79518ad
to
b333ff6
Compare
rvagg
reviewed
Jun 9, 2022
rvagg
reviewed
Jun 9, 2022
rvagg
reviewed
Jun 9, 2022
| @@ -63,11 +69,11 @@ func (n *Node) _bucketSize() int { | |||
| // gets coalesced to -1. | |||
| // We also prevent overflows and underflows, as we convert int64 to int. | |||
| const maxBucketSize = 1 << 20 // 1MiB | |||
There was a problem hiding this comment.
oh, here's a max, but oh boy it's big! we might have to revisit that later, and I don't see an equivalent here for bitWidth which could have worse effects.
rvagg
reviewed
Jun 9, 2022
masih
force-pushed
the
masih/rm-codegen-4-bindnode
branch
from
b333ff6
to
fa3d91a
Compare
Define the HAMT schema in a dedicated ipldsch file and replace the codegen types with go structs using IPLD bindnode. Note the IPLD dependency is updated to the current head of main branch to take advantage of the latest unreleased bindnode fixes.
masih
force-pushed
the
masih/rm-codegen-4-bindnode
branch
from
fa3d91a
to
f1a2395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the HAMT schema in a dedicated ipldsch file and replace the
codegen types with go structs using IPLD bindnode.
Note the IPLD dependency is updated to the current head of main branch
to take advantage of the latest unreleased bindnode fixes.