Commits on Apr 10, 2022

1. node/bindnode: allow nilable types for IPLD optional/nullable …

   For simplicity, bindnode used to always require a pointer to represent
   optional or nullable IPLD types. This is because we need an extra bit to
   store whether the value is absent or null.
   
   However, some Go types can already store a "nil" value to represent that
   bit without needing that extra pointer. Most notably:
   
   	[]T            versus *[]T
   	map[K]V        versus *map[K]V
   	datamodel.Node versus *datamodel.Node
   
   Avoiding the extra pointer makes the types easier for humans to deal
   with, and it also avoids a potential footgun due to the extra "nil"
   state that bindnode doesn't actually use.
   
   Note that we still require pointers for "optional nullable" struct
   fields, as those need two extra bits. A TODO is left for that edge case.
   
   Fixes #378.

   

   mvdan committed Apr 10, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for de57879
   • Browse repository at this point

   Copy the full SHA

   de57879 View commit details

   Browse the repository at this point in the history