This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
Better error handling #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During (de)serialization or returning the CID there might be errors. Return those properly instead of throwing random exceptions.
This way it's easier to find tests to the corresponding functions.
It's more idiomatic to use `deep.equal()` for buffers.
|
For everyone reviewing: It might be easier to review the individual commits as the last one is a refactoring. |
|
@vmx looking good! Do you happen to have a demo of js-ipfs traversing through Bitcoin blocks today? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error handling as well as the corresponding tests.