Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Upgrade to the new IPLD spec #11

Merged
merged 12 commits into from
Apr 11, 2016
Merged

Upgrade to the new IPLD spec #11

merged 12 commits into from
Apr 11, 2016

Conversation

dignifiedquire
Copy link
Member

Items below will not be implemented in this repo

Add ipld.store to store objects either in memory or in ipfs to be used with the resolver
Add ipld.resolve to resolve paths (and links of course)
Add cli tool for interacting

@dignifiedquire
Copy link
Member Author

@diasdavid please enable travis

@daviddias
Copy link
Member

Add ipld.store to store objects either in memory or in ipfs to be used with the resolver
Add ipld.resolve to resolve paths

Note that require('ipld') should be just the data struct and its features, when we can have the IPLD service (similar to DAG and DAGService) that plugs it into a IPFS Repo for storing and/or bitswap for resolving. We don't want to enforce strictly that storing and resolving should be through IPFS.

the IPLD-Service can be behind require('ipld').Service or even as a separate module :)

@daviddias
Copy link
Member

Travis enabled :)

@daviddias
Copy link
Member

moved this repo to IPFS org

//cc @jbenet @nicola

@nicola
Copy link
Member

nicola commented Apr 7, 2016

I love that this is happening.
This work looks really great, I will have to go through it in more detail.
I have wrote last night a trivial demo (https://github.com/nicola/interplanetary-paths) of the scheme that I proposed in ipfs/specs#90 built on json (for the sake of showing how I would like ipld to be)

Last chat I had with Juan there was the issue of // and @link, hence why I started working on my proposal which avoids them (which I think, looking at the implementation and other comments, that we both converged to the same scheme - which is awesome)

ps: I hope to meet in person very soon and describe the full vision and align with you (and participate on this). This effort is so great and it will be a key piece for developers that will build on top of merkle dags/ipfs

@dignifiedquire dignifiedquire mentioned this pull request Apr 7, 2016
})

expect(
file.unmarshal()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it marsheled though?

unmarshal should be something like:

var file = IPLD.unmarshal(cborSerializedIPLDObj)

@dignifiedquire dignifiedquire changed the title [WIP] Upgrade to the new IPLD spec Upgrade to the new IPLD spec Apr 7, 2016
@dignifiedquire
Copy link
Member Author

@diasdavid updated, I think this is ready for the first merge as discussed.

@nicola thanks for the kind words, I will be looking into path resolving in the next couple of days.

before_script:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the npm i npm -g, making tests fail on Node.js 4

@dignifiedquire dignifiedquire mentioned this pull request Apr 8, 2016
3 tasks
@daviddias daviddias merged commit 2d8743a into ipld:master Apr 11, 2016
@daviddias
Copy link
Member

released version 0.5.0 :)

@dignifiedquire dignifiedquire deleted the next branch April 11, 2016 12:51
@dignifiedquire
Copy link
Member Author

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants