Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

If link hashes to serializer are base58 encoded, then decode them [Fi… #43

Merged
merged 2 commits into from Dec 2, 2017
Merged

If link hashes to serializer are base58 encoded, then decode them [Fi… #43

merged 2 commits into from Dec 2, 2017

Conversation

atvanguard
Copy link
Contributor

…xes #28]

@atvanguard
Copy link
Contributor Author

Will add tests, if the current direction of the PR looks good.

@daviddias
Copy link
Member

@atvanguard looking good! Please move on with the tests. Thank you :)

@daviddias daviddias added status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Oct 13, 2017
@daviddias daviddias mentioned this pull request Oct 18, 2017
Closed
@atvanguard
Copy link
Contributor Author

@diasdavid added a test. Feedback welcome :)

@daviddias daviddias merged commit 9f66bca into ipld:master Dec 2, 2017
@daviddias
Copy link
Member

Thank you @atvanguard and apologies for taking so much time to review

@atvanguard atvanguard deleted the dev branch December 2, 2017 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@atvanguard atvanguard

Labels
P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atvanguard @daviddias