This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
feat: add util.cid options #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
suggested changes
Jun 24, 2018
| it('.serialize and .deserialize', (done) => { | ||
| ipldGit.util.serialize(tagNode, (err, serialized) => { | ||
| expect(err).to.not.exist() | ||
| expect(Buffer.isBuffer(serialized)).to.equal(true) |
There was a problem hiding this comment.
Nit-pick: This can be written as expect(Buffer.isBuffer(serialized)).to.be.true(). There's no need to change it, it's just a note for future cases.
src/util.js
Outdated
| * @returns {void} | ||
| */ | ||
| exports.cid = (dagNode, options, callback) => { | ||
| if (options instanceof Function) { |
There was a problem hiding this comment.
Searching through the existing IPFS/IPLD code base it seems that the preferred way for checking if something is a function is: if (typeof options !== 'function') {. My guess is that it is related to code minifiers. Please change it.
vmx
approved these changes
Jun 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipld/interface-ipld-format#40