Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

fix: browser bundle #39

Merged
merged 2 commits into from
Jan 18, 2019
Merged

fix: browser bundle #39

merged 2 commits into from
Jan 18, 2019

Conversation

alanshaw
Copy link
Member

The dist directory was being ignored on publish to npm.

@alanshaw
fix: browser bundle
6c3aec1 
The dist directory was being ignored on publish to npm.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw requested a review from vmx January 17, 2019 16:01
@ghost ghost assigned alanshaw Jan 17, 2019
@ghost ghost added the status/in-progress In progress label Jan 17, 2019
vmx
vmx reviewed Jan 17, 2019
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing inline, let me know if you think it's not worth adding a comment.

.npmignore
@@ -0,0 +1,44 @@
yarn.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first wondered why there's so many things ignored that are never part of this repo. Then I saw that it's a copy of the .gitignore file. I then understood how it helps with the browser bundles.

Could you please for npm noobs like me add a comment at the top along the lines of "This is a copy of .gitignore without ignoring dist, please keep it in sync".

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c370777). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage          ?   92.03%           
=========================================
  Files             ?        7           
  Lines             ?      314           
  Branches          ?        0           
=========================================
  Hits              ?      289           
  Misses            ?       25           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c370777...be77a97. Read the comment docs.

@alanshaw
Copy link
Member Author

Good now @vmx?

@vmx vmx merged commit d7d078f into master Jan 18, 2019
@ghost ghost removed the status/in-progress In progress label Jan 18, 2019
@vmx vmx deleted the fix/browser-bundle branch January 18, 2019 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vmx vmx vmx left review comments

Assignees

@alanshaw alanshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alanshaw @vmx