Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream instead of forks #11

Closed
vmx opened this issue Feb 10, 2020 · 1 comment
Closed

Use upstream instead of forks #11

vmx opened this issue Feb 10, 2020 · 1 comment
Assignees

Comments

@vmx
Copy link
Member

vmx commented Feb 10, 2020

Currently some forks are used. The goal is to get all the changes needed into the upstream crates. This is a tracking issue for the work that needs to done.

I'll work on those and make it a priority. I think it's important to consolidate all existing forks into a single source of truth.

@vmx vmx self-assigned this Feb 10, 2020
@Gozala
Copy link
Contributor

Gozala commented Feb 23, 2020

I've run into the issue with #19, presumably because recent changes in https://github.com/multiformats/rust-multibase that are incompatible with uses in https://github.com/dvc94ch/rust-cid/tree/cli:

/Users/gozala/.cargo/git/checkouts/rust-cid-857ab8699b5b856b/52c079b/src/lib.rs:77:50
   |
77 |         let mut string = multibase::encode(Base::Base58btc, &self.hash.as_ref());
   |                                                  ^^^^^^^^^
   |                                                  |
   |                                                  variant or associated item not found in `multibase::base::Base`
   |                                                  help: there is a variant with a similar name: `Base58Btc`

error[E0599]: no variant or associated item named `Base58btc` found for enum `multibase::base::Base` in the current 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants