New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli interface #33
Conversation
Also adds murmur3 support for #34 |
@dignifiedquire what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets please not start using non rust hashes if we don't have to. I have murmur3 matching the original implementation in rust here: https://github.com/dignifiedquire/murmur3 (fork of another crate)
actually there was no fix, I just improved the api, so you could just use the original version here: https://github.com/stusmall/murmur3 |
The API changed quite a bit with the release of 0.10.0 so this would need a rebase. If you still have interest in providing a CLI, please make this PR (or create a new one) with the CLI changes only and without adding the murmur hashing (that should be a separate PR). |
I'll reopen if I get around to it, I think it would be useful to have |
I agree that it would be useful, thanks! |
As a well behaved unix library it should have a cli :)