Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli interface #33

Closed
wants to merge 7 commits into from
Closed

Add cli interface #33

wants to merge 7 commits into from

Conversation

dvc94ch
Copy link
Collaborator

@dvc94ch dvc94ch commented Sep 1, 2019

As a well behaved unix library it should have a cli :)

@coveralls
Copy link

coveralls commented Sep 1, 2019

Coverage Status

Coverage increased (+9.7%) to 53.91% when pulling dc50307 on dvc94ch:cli into 9f53e95 on multiformats:digest.

@dvc94ch
Copy link
Collaborator Author

dvc94ch commented Sep 6, 2019

Also adds murmur3 support for #34

@dvc94ch
Copy link
Collaborator Author

dvc94ch commented Sep 14, 2019

@dignifiedquire what do you think?

Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets please not start using non rust hashes if we don't have to. I have murmur3 matching the original implementation in rust here: https://github.com/dignifiedquire/murmur3 (fork of another crate)

@dignifiedquire
Copy link
Member

actually there was no fix, I just improved the api, so you could just use the original version here: https://github.com/stusmall/murmur3

@vmx
Copy link
Member

vmx commented Feb 26, 2020

The API changed quite a bit with the release of 0.10.0 so this would need a rebase. If you still have interest in providing a CLI, please make this PR (or create a new one) with the CLI changes only and without adding the murmur hashing (that should be a separate PR).

@dvc94ch
Copy link
Collaborator Author

dvc94ch commented Feb 26, 2020

I'll reopen if I get around to it, I think it would be useful to have

@dvc94ch dvc94ch closed this Feb 26, 2020
@vmx
Copy link
Member

vmx commented Feb 26, 2020

I agree that it would be useful, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants