add OpenBMC D-Bus interface #100
Conversation
|
Hmmm. looks like my configure.ac stuff didn't work right.... I will look into it. The code works (I am running it on my BMC right now.) But the CI build doesn't have systemd development files installed and the configure fails to disable the dbus interface. I will work on this. |
vmauery
force-pushed
the
feature/dbus-interface
branch
from
49573f4
to
4923fcf
Compare
|
The build that passed above doesn't actually build this code. By default, the dbus interface doesn't build. To get it to build, --enabled-intf-dbus must be passed to ./configure. If configure does not detect libsystemd, and the caller requested the dbus interface, configure will fail, saying it needs libsystemd. If systemd is present, and the caller requests the dbus interface, it will be built. |
vmauery
force-pushed
the
feature/dbus-interface
branch
from
4923fcf
to
6a4e49d
Compare
|
I realized that it has some code style issues. I think I got them all... |
|
Some review comments are outdated, please ignore them as I can see that you've already addressed them. |
vmauery
force-pushed
the
feature/dbus-interface
branch
from
6a4e49d
to
b261374
Compare
|
Is is possible to be able to have the CI actually build with --enable-intf-dbus? It would need to have the system systemd-devel package installed. But because this interface is disabled by default, the CI doesn't actually build it. It does build on my machine but my machine is a snowflake. :) |
|
Are there still fixups that need to be done here? I think I have addressed all the comments. Can this get merged? |
OpenBMC runs a D-Bus interface internally and has the option of compiling ipmitool so it can run natively on the BMC. This adds the D-Bus interface to ipmitool so it can be used with the OpenBMC project. Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
vmauery
force-pushed
the
feature/dbus-interface
branch
from
5e10118
to
980ba49
Compare
|
This new set pulls in some file-level static variables into a function scope and replaces some strings with some systemd-defined types. It is much more verbose, but doesn't include any hard-coded values. |
|
Adding a bbappend for ipmitool that pulls in this commit and appends a configure option: This builds for ast2500 and runs as expected on an openBMC build. |
Yes, you can update |
|
It looks like the CI is running on a 14.04 ubuntu system. This is before systemd was available in ubuntu. 16.04 or 18.04 will work just fine. Is there a way to change that? |
By default the D-Bus interface is not enabled, so in order to get it to build in Travis, it must be enabled explicitly. This installs the packages needed and sets the configure flag. Signed-off-by: Vernon Mauery <vernon.mauery@intel.com>
vmauery
force-pushed
the
feature/dbus-interface
branch
from
1d53081
to
ec81edd
Compare
|
Nevermind. I got it. :) I watched it build the dbus interface in Travis. Zero new warnings. https://travis-ci.com/ipmitool/ipmitool/builds/108379984 |
OpenBMC runs a D-Bus interface internally and has the option of
compiling ipmitool so it can run natively on the BMC. This adds the
new OpenBMC IPMI D-Bus interface to ipmitool so it can be used
with the OpenBMC project.
Signed-off-by: Vernon Mauery vernon.mauery@linux.intel.com