create_pen_list: only print if values are set #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmauery
force-pushed
the
bugfix/pen_list
branch
from
19df02d
to
ab40981
Compare
This change only affects the building of ipmitool. If the remote server that the PEN list is downloaded from is unavailable, or the machine building ipmitool is offline, then this allows the build to succeed, using a mostly-empty list instead of the full IANA PEN list. |
AlexanderAmelkin
previously approved these changes
May 29, 2019
On a failed download of the PEN list, the create_pen_list script
improperly printed an invalid entry of { , "" } causing the build to
fail. The last line print must check that it has something to print or
it will print the wrong thing.
Partially resolves ipmitool#11
Signed-off-by: Vernon Mauery <vernon.mauery@intel.com>
AlexanderAmelkin
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a build environment doesn't have network access the fetch of the IANA PEN list will fail and the create_pen_list script will create invalid output causing the build to fail. This fixes the parsing.