Skip to content

company name change from Newisys to Viking Enterprise #127

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

danm3986
Copy link
Contributor

Renamed the strings containing Newisys to Viking
Built and tested with AMI's IPMI stack 12LTS.
bugfix/124

Signed-off-by: dan mcgee dan.mcgee@vikingenterprise.com
Signed-off-by: dan mcgee dan.mcgee@sanmina.com

Copy link
Contributor

@AlexanderAmelkin AlexanderAmelkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change commit log to:

sel: Change name from Newisys to Viking Enterprise

Renamed the strings containing Newisys to Viking
Built and tested with AMI's IPMI stack 12LTS.

Resolves ipmitool/ipmitool#124

Signed-off-by: dan mcgee <dan.mcgee@vikingenterprise.com>
Signed-off-by: dan mcgee <dan.mcgee@sanmina.com>

Besides, the IANA PEN registry still has 9237 registered to Newisys. Please update the registration with IANA before I merge this (ipmitool anyway takes the vendor name string directly from IANA's list).

@@ -283,7 +283,7 @@ typedef enum IPMI_OEM {
IPMI_OEM_MAGNUM = 5593,
IPMI_OEM_TYAN = 6653,
IPMI_OEM_QUANTA = 7244,
IPMI_OEM_NEWISYS = 9237,
IPMI_OEM_VIKING_ENTERPRISE_SOL = 9237,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please limit this to just IPMI_OEM_VIKING. I don't see any other vikings around, so let's be terse.

@danm3986
Copy link
Contributor Author

danm3986 commented Jun 3, 2019 via email

Renamed the oem strings containing Newisys to Viking Enterprise Solutions.
IANA 9237
Built and tested with AMI's IPMI stack LTS 12.01.

Resolves ipmitool#124

Signed-off-by: dan mcgee <dan.mcgee@vikingenterprise.com>
Signed-off-by: dan mcgee <dan.mcgee@sanmina.com>
@AlexanderAmelkin AlexanderAmelkin merged commit 8071cf7 into ipmitool:master Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants