-
Notifications
You must be signed in to change notification settings - Fork 356
company name change from Newisys to Viking Enterprise #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderAmelkin
suggested changes
Jun 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change commit log to:
sel: Change name from Newisys to Viking Enterprise
Renamed the strings containing Newisys to Viking
Built and tested with AMI's IPMI stack 12LTS.
Resolves ipmitool/ipmitool#124
Signed-off-by: dan mcgee <dan.mcgee@vikingenterprise.com>
Signed-off-by: dan mcgee <dan.mcgee@sanmina.com>
Besides, the IANA PEN registry still has 9237 registered to Newisys. Please update the registration with IANA before I merge this (ipmitool anyway takes the vendor name string directly from IANA's list).
include/ipmitool/ipmi.h
Outdated
@@ -283,7 +283,7 @@ typedef enum IPMI_OEM { | |||
IPMI_OEM_MAGNUM = 5593, | |||
IPMI_OEM_TYAN = 6653, | |||
IPMI_OEM_QUANTA = 7244, | |||
IPMI_OEM_NEWISYS = 9237, | |||
IPMI_OEM_VIKING_ENTERPRISE_SOL = 9237, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please limit this to just IPMI_OEM_VIKING
. I don't see any other vikings around, so let's be terse.
thanks you working on it.
…On Mon, Jun 3, 2019 at 5:16 AM Alexander Amelkin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Please change commit log to:
oem: Change name from Newisys to Viking Enterprise
Renamed the strings containing Newisys to Viking
Built and tested with AMI's IPMI stack 12LTS.
Resolves ipmitool/ipmitool#124
Signed-off-by: dan mcgee ***@***.***>
Signed-off-by: dan mcgee ***@***.***>
Besides, the IANA PEN registry still has 9237 registered to Newisys.
Please update the registration with IANA before I merge this (ipmitool
anyway takes the vendor name string directly from IANA's list).
------------------------------
In include/ipmitool/ipmi.h
<#127 (comment)>:
> @@ -283,7 +283,7 @@ typedef enum IPMI_OEM {
IPMI_OEM_MAGNUM = 5593,
IPMI_OEM_TYAN = 6653,
IPMI_OEM_QUANTA = 7244,
- IPMI_OEM_NEWISYS = 9237,
+ IPMI_OEM_VIKING_ENTERPRISE_SOL = 9237,
Let's please limit this to just IPMI_OEM_VIKING. I don't see any other
vikings around, so let's be terse.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#127?email_source=notifications&email_token=AMCTCT5WMURYJD4R3VHNBQDPYT4QVA5CNFSM4HR5LZXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2LZFPI#pullrequestreview-244814525>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMCTCT3N6W4IWLI3EWA5QG3PYT4QVANCNFSM4HR5LZXA>
.
--
Dan McGee
Engineer
Newisys - A Division of Sanmina Corporation
5385 Mark Dabling Blvd., Suite 100
Colorado Springs, CO 80918
*Cell - 719 243 9353*
dan.mcgee@sanmina.com <randi.suttles@sanmina.com>
--
CONFIDENTIALITY
This e-mail message and any attachments thereto, is
intended only for use by the addressee(s) named herein and may contain
legally privileged and/or confidential information. If you are not the
intended recipient of this e-mail message, you are hereby notified that any
dissemination, distribution or copying of this e-mail message, and any
attachments thereto, is strictly prohibited. If you have received this
e-mail message in error, please immediately notify the sender and
permanently delete the original and any copies of this email and any prints
thereof.
ABSENT AN EXPRESS STATEMENT TO THE CONTRARY HEREINABOVE, THIS
E-MAIL IS NOT INTENDED AS A SUBSTITUTE FOR A WRITING. Notwithstanding the
Uniform Electronic Transactions Act or the applicability of any other law
of similar substance and effect, absent an express statement to the
contrary hereinabove, this e-mail message its contents, and any attachments
hereto are not intended to represent an offer or acceptance to enter into a
contract and are not otherwise intended to bind the sender, Sanmina
Corporation (or any of its subsidiaries), or any other person or entity.
|
Renamed the oem strings containing Newisys to Viking Enterprise Solutions. IANA 9237 Built and tested with AMI's IPMI stack LTS 12.01. Resolves ipmitool#124 Signed-off-by: dan mcgee <dan.mcgee@vikingenterprise.com> Signed-off-by: dan mcgee <dan.mcgee@sanmina.com>
This was referenced Jun 10, 2019
AlexanderAmelkin
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the strings containing Newisys to Viking
Built and tested with AMI's IPMI stack 12LTS.
bugfix/124
Signed-off-by: dan mcgee dan.mcgee@vikingenterprise.com
Signed-off-by: dan mcgee dan.mcgee@sanmina.com