Skip to content

Use -n to omit timestamps in manpages for reproducablity #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use -n to omit timestamps in manpages for reproducablity #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.am
View file
Open in desktop
Expand Up @@ -85,7 +85,7 @@ pkg: control/pkginfo
$(STRIP) src/ipmitool
(cd control ; pkgmk -o -d /tmp)
pkgtrans -s /tmp $(PKG) ipmitool
gzip -c /tmp/$(PKG) > $(PKG).gz
gzip -nc /tmp/$(PKG) > $(PKG).gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you really using Solaris? As far as I can see, the whole pkg target is non-functional on Linux (at least Ubuntu) because there are no pkgmk and pkgtrans tools.

Is this really an issue on Solaris? Is this the only thing that prevents reproducible builds for you?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I am working on yocto based linux in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not that I'm totally against this change, but I'm still not convinced that it is actually needed. How come that a Yocto-based Linux uses this Makefile target? In the default openembedded recipe for ipmitool I do not see any references to this target, as well as I don't see any recipe that provides pkgtrans that is required for this target.

It still looks like this target is some kind of atavism and needs to be removed rather than patched.

Am I wrong?

-rm -rf /tmp/ipmitool /tmp/$(PKG)

BUILDDIR = ${shell cd $(top_builddir) ; pwd | sed -e 's,^[^:\\/]:[\\/],/,'}
Expand Down