Fixed compiler warning. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shitalkumar-gandhi
force-pushed
the
master
branch
from
969ac9c
to
46f6e82
Compare
AlexanderAmelkin
suggested changes
Feb 9, 2021
lib/ipmi_tsol.c
Outdated
| @@ -534,7 +534,7 @@ ipmi_tsol_main(struct ipmi_intf *intf, int argc, char **argv) | |||
|
|
|||
| if ((fds[0].revents & POLLIN) && (sizeof(out_buff) > out_buff_fill)) { | |||
| socklen_t sin_len = sizeof(sin); | |||
| int buff_size = sizeof(buff); | |||
| unsigned short int buff_size = sizeof(buff); | |||
There was a problem hiding this comment.
The type of sizeof() is size_t, please use it. Please remember that there are different architectures too.
There was a problem hiding this comment.
The type of
sizeof()issize_t, please use it. Please remember that there are different architectures too.
Thanks, done.
shitalkumar-gandhi
force-pushed
the
master
branch
from
46f6e82
to
a163745
Compare
This patch has been added to fix "error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]" Signed-off-by: Shitalkumar Gandhi <shitalkumar.gandhi@seagate.com>
shitalkumar-gandhi
force-pushed
the
master
branch
from
a163745
to
22dea14
Compare
AlexanderAmelkin
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch has been added to fix "error: comparison between signed
and unsigned integer expressions [-Werror=sign-compare]"
Signed-off-by: Shitalkumar Gandhi shitalkumar.gandhi@seagate.com