Implement ndjson HTTP delegated routing GET API
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the streaming API for HTTP delegated routing. The lookup response can now be encoded as IPNI response payload or HTTP delegated routing `GET` provider records.
masih
force-pushed
the
masih/http_dr_response
branch
from
76f4a29
to
73bf595
Compare
willscott
approved these changes
Jan 28, 2023
|
Not sure what you mean? |
willscott
reviewed
Jan 29, 2023
Comment on lines
+77
to
+79
| if d.f != nil { | ||
| d.f.Flush() | ||
| } |
There was a problem hiding this comment.
flushes will be relatively expensive. we should understand how many packets we're potentially sharding a respond into and try hard to minimize it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the streaming API for HTTP delegated routing. The lookup response can now be encoded as IPNI response payload or HTTP delegated routing
GETprovider records.