Do not add extra newline after streaming json response

json.Encoder.Encode already adds a newline after each record: https://pkg.go.dev/encoding/json#Encoder.Encode
ipni · Jul 18, 2023 · 2236950 · 2236950
1 parent caa0bba
commit 2236950
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/rwriter/provider_response_writer.go b/rwriter/provider_response_writer.go
@@ -28,9 +28,7 @@ func (pw *ProviderResponseWriter) WriteProviderResult(pr model.ProviderResult) e
 		if err != nil {
 			return err
 		}
-		if err = pw.WriteND(); err != nil {
-			return err
-		}
+		pw.Flush()
 	} else {
 		pw.result.ProviderResults = append(pw.result.ProviderResults, pr)
 	}

diff --git a/rwriter/response_writer.go b/rwriter/response_writer.go
@@ -144,15 +144,10 @@ func (w *ResponseWriter) PathType() string {
 	return w.pathType
 }
 
-func (w *ResponseWriter) WriteND() error {
-	_, err := w.w.Write([]byte("\n"))
-	if err != nil {
-		return err
-	}
+func (w *ResponseWriter) Flush() {
 	if w.f != nil {
 		w.f.Flush()
 	}
-	return nil
 }
 
 func (w *ResponseWriter) Cid() cid.Cid {