Implement deal and provider coverage calculation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement metrics that calculate deals and provider coverage by the indexer. Deal coverage is calculated as: sum of deals discoverable by the indexer divided by total discoverable deals. The term "discoverable" here implies that the provider of the deal has a non-nil address discovered via FileCoin API. Provider coverage is calculated as: number of providers known by the indexer with at least one deal divided by total number of discoverable providers with at least one deal. This commit also removes WIP test files pushed by accident in earlier PRs. Fixes #5
masih
force-pushed
the
masih/coverage_ratio_metrics
branch
from
7c37e09
to
d535f1b
Compare
willscott
reviewed
Nov 25, 2022
| ds.dealCountByParticipant = dealCountByParticipant | ||
| ds.refreshLock.Unlock() | ||
| ds.hf.metrics.notifyDealCount(totalDealCount) | ||
| logger.Infow("fetched state market deals", "count", totalDealCount) |
There was a problem hiding this comment.
rather than just doing dealCount - it would be interesting if we could try correlate on contextID since we know filecoin providers will put in their deal ID as the context ID
There was a problem hiding this comment.
Sounds good.
What's here is equivalent to how we measure it in index-observer.
Ok to do this in a separate PR?
willscott
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement metrics that calculate deals and provider coverage by the indexer.
Deal coverage is calculated as: sum of deals discoverable by the indexer divided by total discoverable deals. The term "discoverable" here implies that the provider of the deal has a non-nil address discovered via FileCoin API.
Provider coverage is calculated as: number of providers known by the indexer with at least one deal divided by total number of discoverable providers with at least one deal.
This commit also removes WIP test files pushed by accident in earlier PRs.
Fixes #5