Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure traffic volume on PUT requests to /routing/v1/* #54

Closed
3 tasks done
masih opened this issue Dec 13, 2022 · 1 comment · Fixed by #55
Closed
3 tasks done

Measure traffic volume on PUT requests to /routing/v1/* #54

masih opened this issue Dec 13, 2022 · 1 comment · Fixed by #55
Assignees
@masih

Comments

@masih
Copy link
Member

masih commented Dec 13, 2022 •
edited

Add metrics that measure the number of requests requesting PUT on /routing/v1/* in order to build understanding of volume event though PUT on that path is not implemented by indexstar.
@masih masih self-assigned this Dec 13, 2022
@lidel
Copy link

lidel commented Dec 13, 2022

cc ipfs/specs#337 @guseggert @ajnavarro

@masih masih mentioned this issue Dec 13, 2022
Merged
masih added a commit that referenced this issue Dec 14, 2022
@masih
Count HTTP delegated routing calls by method and return 501 on PUT
9b035cf 
Count the number of calls made to the HTTP delegated routing tagged by
method.

Explicitly return `501 Not Implemented` on `PUT` to
`/routing/v1/providers`. This is to identify that putting provider
records is not currently implemented by `cid.contact`.

Relates to:
- ipfs/specs#337 (comment)

Fixes #54
@masih masih mentioned this issue Dec 14, 2022
Merged
masih added a commit that referenced this issue Dec 14, 2022
@masih
Count HTTP delegated routing calls by method and return 501 on PUT
44cab9f 
Count the number of calls made to the HTTP delegated routing tagged by
method.

Explicitly return `501 Not Implemented` on `PUT` to
`/routing/v1/providers`. This is to identify that putting provider
records is not currently implemented by `cid.contact`.

Relates to:
- ipfs/specs#337 (comment)

Fixes #54
@masih masih closed this as completed in #55 Dec 15, 2022
masih added a commit that referenced this issue Dec 15, 2022
@masih
Count HTTP delegated routing calls by method and return 501 on PUT
f62bd46 
Count the number of calls made to the HTTP delegated routing tagged by
method.

Explicitly return `501 Not Implemented` on `PUT` to
`/routing/v1/providers`. This is to identify that putting provider
records is not currently implemented by `cid.contact`.

Relates to:
- ipfs/specs#337 (comment)

Fixes #54
masih added a commit to ipni/storetheindex that referenced this issue Dec 15, 2022
@masih
Deploy HTTP delegated routing metrics to dev
8b51215 
Deploy latest `indexstar` to `dev`.

Relates to:
- ipni/indexstar#54
@masih masih mentioned this issue Dec 15, 2022
Merged
masih added a commit to ipni/storetheindex that referenced this issue Dec 15, 2022
@masih
Deploy HTTP delegated routing metrics to dev
785e8ce 
Deploy latest `indexstar` to `dev`.

Relates to:
- ipni/indexstar#54
masih added a commit that referenced this issue Dec 15, 2022
@masih
Fix response to PUT at root of /routing/v1/providers
cbb93e3 
`PUT` requests are sent to the root of `/routing/v1/providers`. This
won't match the pattern of current `find` handler function. Separate the
handler and explicitly return `501`.

Relates to: #54
@masih masih mentioned this issue Dec 15, 2022
Merged
masih added a commit that referenced this issue Dec 15, 2022
@masih
Fix response to PUT at root of /routing/v1/providers
71f74bc 
`PUT` requests are sent to the root of `/routing/v1/providers`. This
won't match the pattern of current `find` handler function. Separate the
handler and explicitly return `501`.

Relates to: #54
masih added a commit that referenced this issue Dec 15, 2022
@masih
Fix response to PUT at root of /routing/v1/providers
67c9360 
`PUT` requests are sent to the root of `/routing/v1/providers`. This
won't match the pattern of current `find` handler function. Separate the
handler and explicitly return `501`.

Relates to: #54
masih added a commit to ipni/storetheindex that referenced this issue Dec 15, 2022
@masih
Deploy metrics and route fix for HTTP delegated routing on prod
7ef24c5 
Deployed and tested on `dev` already; rolling out on `prod`.

Relates to:
- ipni/indexstar#54
@masih masih mentioned this issue Dec 15, 2022
Merged
masih added a commit to ipni/storetheindex that referenced this issue Dec 15, 2022
@masih
Deploy metrics and route fix for HTTP delegated routing on prod
c364eb5 
Deployed and tested on `dev` already; rolling out on `prod`.

Relates to:
- ipni/indexstar#54
@masih masih changed the title Measure traffic volume on PUT requests to `/routing/v1/* Measure traffic volume on PUT requests to /routing/v1/* Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Count HTTP delegated routing calls by method and return 501 on PUT ipni/indexstar
2 participants
@lidel @masih