Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the binary name ipni #6

Closed
masih opened this issue May 2, 2023 · 2 comments · Fixed by #12
Closed

Use the binary name ipni #6

masih opened this issue May 2, 2023 · 2 comments · Fixed by #12

Comments

@masih
Copy link
Member

masih commented May 2, 2023

Restructure code or rename the repo such that the IPNI cli executable is simply ipni. On restructuring the code, we can achieve this by moving the main to cmd/ipni package.

@gammazero
Copy link
Contributor

My vote is to have the repo name match the executable name. That also simplifies the install.

How about we call it nicl (network indexer command line). That's really easy to remember. 🪙

@masih
Copy link
Member Author

masih commented May 9, 2023

My vote is to reduce terminology and stick with ipni. My preferred option would be to achieve this with either a CI build --out parameter and release binaries along with homebrew formula to make it easy to install, or use a simple cmd/ipni package.

gammazero added a commit that referenced this issue May 9, 2023
- Command main package is now under cmd/ipni
- Individual command packages and utilities are under pkg/

Fixes #6
gammazero added a commit that referenced this issue May 9, 2023
- Command main package is now under cmd/ipni
- Individual command packages and utilities are under pkg/

Fixes #6
gammazero added a commit that referenced this issue May 10, 2023
* Restructure commands under cmd and pkg directories

- Command main package is now under cmd/ipni
- Individual command packages and utilities are under pkg/

Fixes #6

* Add distance command
* fix redundant import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants